Rework broadcasting machinery#355
Open
ptiede wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the broadcasting machinery to fix the ambiguity and other issues that were originally pointed out in rafaqz/DimensionalData.jl#1195
I've taken a lot of inspiration from what DimensionalData did in their implementation, but with a couple of changes to handle cases where the underlying data isn't actually an array. One of the outcomes of this is that the dimensionality (ndims) of the broadcast hooks into Julia's own styles through BroadcastStyle, which means that sometimes, instead of inferring e.g.,
DefaultArrayStyle{N}for the ArrayStyle, it givesDefaultArrayStyle{Any}.I'm not as familiar with the broadcasting internals as I should be, so I am not entirely sure about whether this changes anything downstream. I didn't notice any degradation, but this is potentially a breaking change, so it should be reviewed pretty closely.